jgraham: armenzg_brb: This new logging in mozdevice is awesome!We recently changed the way that mozdevice works. mozdevice is a python package used to talk to Firefox OS or Android devices either through ADB or SUT.armenzg: jgraham, really? why you say that?
jgraham: armenzg: I can see what's going on!
Several developers of the Auto Tools team have been working on the Firefox OS certification suite for partners to determine if they meet the expectations of the certification process for Firefox OS.
When partners have any issues with the cert suite, they can send us a zip file with their results so we can help them out. However, until recently, the output of mozdevice would go to standard out rather than being logged into the zip file they would send us.
In order to use the log manger inside the certification suite, I needed every adb command and its output to be logged rather than printed to stdout. Fortunately, mozprocess has a parameter that I can specify which allows me to manipulate any output generate by the process. To benefit from mozprocess and its logging, I needed to switch every subprocess.Popen() call to be replaced by ProcessHandler().
If you want to "see what's going on" in mozdevice, all you have to do is to request the debug level of logging like this:
DeviceManagerADB(logLevel=mozlog.DEBUG)As part of this change, we also switched to use structured logging instead of the basic mozlog logging.
Switching to mozprocess also helped us discover an issue in mozprocess specific to Windows.
You can see the patch in here.
You can see other changes inside of the mozdevice 0.38 release in here.
At least with mozdevice you can know what is going on! |
This work by Zambrano Gasparnian, Armen is licensed under a Creative Commons Attribution-Noncommercial-Share Alike 3.0 Unported License.